ast: Allow non-infix and()/or() set built-in calls - #9012
Open
johanfylling wants to merge 2 commits into
Open
Conversation
The `and`/`or` keywords are infix operators, so when they appear in a term position immediately followed by an opening parens (`(`) there is no ambiguity that we're dealing with a function call and not a logical operation. Being permissive in this position allow users to keep calling the named form (`and()`/`or()`) of the set built-ins (`&`/`|` infixes). Note: calling the named functions, as opposed to using the infix form, is likely very rare, but we can't guarantee this form is never used. Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Conflicts: v1/ast/parser_logical_test.go
sspaink
reviewed
Aug 14, 2026
| // `z and (1 + 2) > 3` is accepted -- the same shape is plain v1 syntax after | ||
| // `not`, see TestParseLogical_ParenNot. | ||
| { | ||
| note: "rhs operand, leading part wrapped", |
Member
There was a problem hiding this comment.
did you mean to delete these test cases? They were added in github.com//pull/9006 so I was thinking maybe merge conflict accident?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
and/orkeywords are infix operators, so when they appear in a term position immediately followed by an opening parens (() there is no ambiguity that we're dealing with a function call and not a logical operation.Being permissive in this position allow users to keep calling the named form (
and()/or()) of the set built-ins (&/|infixes).Note: calling the named functions, as opposed to using the infix form, is likely very rare, but we can't guarantee this form is never used.